Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update segment to send "common fields" #1726

Closed
unn opened this issue Jul 23, 2019 · 1 comment
Closed

Update segment to send "common fields" #1726

unn opened this issue Jul 23, 2019 · 1 comment

Comments

@unn
Copy link
Contributor

unn commented Jul 23, 2019

Describe the bug
Our custom OS, ddev_version, and instrumentation_user should be updated to leverage common fields, see links below.

Expected behavior
Our custom implementation of OS should be replaced by the common field os.
Our custom implementation of ddev_version should be replaced by the common field app version.
Our custom implementation of instrumentation_user should be replaced with a common trait like name or a custom trait.

Additional context
https://segment.com/docs/spec/common/#context
https://github.com/segmentio/analytics-go/blob/v3.0/context.go#L95 
https://github.com/segmentio/analytics-go/blob/v3.0/context.go#L39 

@rfay rfay added this to the v1.10 milestone Jul 24, 2019
@rfay
Copy link
Member

rfay commented Jul 24, 2019

While doing this:

  • Consider moving the global_config.yaml specification of a known user to a specific field of its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants