New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide clearer feedback when a hook's "exec" or "exec-host" task fails #1765
Comments
I've seen similar feedback at the end of other command tools like brew or maybe npm/yarn/gulp. It would say something like "There was a problem running the command. Read the error messages from earlier in the report. This is not an error with brew." Or something. |
Thanks for the good report. The next time you run across a better style of reporting, could you capture it in a screenshot and put it here? Hopefully it will be long since fixed by then, but well, things aren't always ;) |
This react and babel issue gives an example of some of the potential language you could use when a hook has exited with a nonzero status code.
|
Thanks! |
ddev exec
command fails
@greggles would love to see what you think of the PR in #1860, artifacts are listed at #1860 (comment) |
Is your feature request related to a problem? Please describe.
When a hook runs and the command it's running fails the output can be pretty disorienting. It made me wonder if ddev was broken somehow.
Describe the solution you'd like
It would be nice if the output showing errors could also suggest to the user something like "Try commenting out the hook and rerunning the command with ddev exec." When it fails in
ddev exec
it could also be good to say "Try running with ddev ssh."Describe alternatives you've considered
It could also be good to truncate the output and say "Some of the output is shown here. Rerun the command using
ddev exec
to view all the error output."Additional context
https://gist.github.com/greggles/77865f1ef2da06cf05fd0b8aec3b1c42
The text was updated successfully, but these errors were encountered: