Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nginx overrides of "http" context, not just "server" context #1957

Closed
gilbertsoft opened this issue Nov 18, 2019 · 2 comments
Closed

Comments

@gilbertsoft
Copy link
Member

Is your feature request related to a problem? Please describe.
Some configurations like the server directive for another website are possible at http context only but DDEV offers only includes for the server context.

Describe the solution you'd like
It would be nice to have the same feature as for the server context (files in .ddev/nginx/) available for the http context. This could be simply achieved by the line include /mnt/ddev_config/nginx/http/*.conf; after the last server block.

Ofc same would be nice for Apache too, but I never had to change the Apache configuration so far and I don't know the details of the available options there.

Describe alternatives you've considered
Alternative is currently to provide the full nginx configuration.

Additional context
This would be a quick solution for the issues #1850 and #1889 too.

@rfay rfay changed the title nginx includes at http context Allow nginx overrides of "http" context, not just "server" context Nov 18, 2019
@rfay
Copy link
Member

rfay commented Nov 18, 2019

Thanks!

@rfay
Copy link
Member

rfay commented Jun 1, 2020

Closing in favor of #2263 - That will allow much more user configuration of nginx, including multiple docroots/subsites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants