New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
findDirectivesInScriptCommand trims quotes from custom command files, breaks help text of provided commands #3051
Comments
Good eye! Want to do a PR? You don't even need a development environment to work on it and test with gitpod. https://gitpod.io/#https://github.com/drud/ddev More hints in https://github.com/drud/ddev/blob/master/docs/developers/building-contributing.md |
diegoe
added a commit
to diegoe/ddev
that referenced
this issue
Jun 17, 2021
In 2ff4f0b, triming was added for readability of file paths but the code does not actually depend on quotes around paths. It only cares for commas to differentiate multiple paths in a given directive. Fixes: ddev#3051 This partially reverts: commit 2ff4f0b Author: Andreas Hager <3351175+andreashager@users.noreply.github.com> Date: Tue Dec 29 05:47:40 2020 +0100 Create new HeidiSQL command for Windows and WSL2 (ddev#2679)
diegoe
added a commit
to diegoe/ddev
that referenced
this issue
Jun 17, 2021
In 2ff4f0b, triming was added for readability of file paths but the code does not actually depend on quotes around paths. It only cares for commas to differentiate multiple paths in a given directive. This partially reverts: commit 2ff4f0b Author: Andreas Hager <3351175+andreashager@users.noreply.github.com> Date: Tue Dec 29 05:47:40 2020 +0100 Create new HeidiSQL command for Windows and WSL2 (ddev#2679)
diegoe
added a commit
to diegoe/ddev
that referenced
this issue
Jun 17, 2021
In 2ff4f0b, trimming was added for readability of file paths but the code does not actually depend on quotes around paths. It only cares for commas to differentiate multiple paths in a given directive. This partially reverts: commit 2ff4f0b Author: Andreas Hager <3351175+andreashager@users.noreply.github.com> Date: Tue Dec 29 05:47:40 2020 +0100 Create new HeidiSQL command for Windows and WSL2 (ddev#2679)
rfay
pushed a commit
to diegoe/ddev
that referenced
this issue
Jul 12, 2021
In 2ff4f0b, trimming was added for readability of file paths but the code does not actually depend on quotes around paths. It only cares for commas to differentiate multiple paths in a given directive. This partially reverts: commit 2ff4f0b Author: Andreas Hager <3351175+andreashager@users.noreply.github.com> Date: Tue Dec 29 05:47:40 2020 +0100 Create new HeidiSQL command for Windows and WSL2 (ddev#2679)
rfay
pushed a commit
that referenced
this issue
Jul 13, 2021
rfay
pushed a commit
to rfay/ddev
that referenced
this issue
Jul 14, 2021
This was fixed in #3057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In
findDirectivesInScriptCommand
, spaces, quotes, and double quotes, are trimmed from strings in the command description:This breaks the formatting of help lines in the default provided commands (example,
cmd/ddev/cmd/global_dotddev_assets/commands/web/drush
)Versus the source:
To Reproduce
Run commands like
ddev drush --help
Expected behavior
String is passed as is, or at least the provided commands don't fall into this bug.
Version and configuration information (please complete the following information):
ddev version
)Additional context
The text was updated successfully, but these errors were encountered: