-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopped site can result in double notifications about router #393
Comments
Needs a confirm and then hopefully it's a quick fix. Thanks, @rfay! |
I can reproduce the double-warning output on macOS. The double-warning is not intended, but the warning message shown for this state is valid and intended. With no sites running, there is no router, and no sites are accessible. |
I guess I disagree about the router notification when there are only stopped sites. I would expect a reasonable user to understand that stopped sites are not accessible. |
At a minimum, a double warning (even if it's benign) is going to be seen as an oddity to an end-user. If it's a simple LOE to address, my vote would be to correct this. |
Not prioritized yet until we have reviewed the backlog. |
I ran across this in #483 so fixed it there. |
What happened (or feature request):
ddev list
Ddev shows a single site, as stopped, correctly.
It shows DDEV ROUTER STATUS: not found (incorrect, as we wouldn't expect to find it)
And it shows two separate warnings "The router is not currently running. Your sites are likely inaccessible at this time.Try running 'ddev start' on a site to recreate the router"
What you expected to happen:
No warnings about the router.
Version: Please include the output of
ddev version
and the project's .ddev/config.yaml.(This particular test was on linux)
How to reproduce this:
Anything else do we need to know:
Related source links or issues:
The text was updated successfully, but these errors were encountered: