Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped site can result in double notifications about router #393

Closed
rfay opened this issue Jul 11, 2017 · 6 comments · Fixed by #483
Closed

Stopped site can result in double notifications about router #393

rfay opened this issue Jul 11, 2017 · 6 comments · Fixed by #483
Milestone

Comments

@rfay
Copy link
Member

rfay commented Jul 11, 2017

What happened (or feature request):

  • Start one site
  • Stop the site
  • ddev list

Ddev shows a single site, as stopped, correctly.
It shows DDEV ROUTER STATUS: not found (incorrect, as we wouldn't expect to find it)
And it shows two separate warnings "The router is not currently running. Your sites are likely inaccessible at this time.Try running 'ddev start' on a site to recreate the router"

$ ddev list
1 local site found.
NAME                TYPE     LOCATION                          URL                                   STATUS
TestMainCmdDrupal8  drupal8  /tmp/TestMainCmdDrupal8331317292  http://TestMainCmdDrupal8.ddev.local  stopped

DDEV ROUTER STATUS: not found
The router is not currently running. Your sites are likely inaccessible at this time.
Try running 'ddev start' on a site to recreate the router.
The router is not currently running. Your sites are likely inaccessible at this time.
Try running 'ddev start' on a site to recreate the router.

What you expected to happen:

No warnings about the router.

Version: Please include the output of ddev version and the project's .ddev/config.yaml.

(This particular test was on linux)

$ ddev version
cli:       	v0.7-44-gf1973c0
web:       	drud/nginx-php-fpm7-local:v0.7.3
db:        	drud/mysql-local-57:20170708_windows_works
dba:       	drud/phpmyadmin:v0.2.0
router:    	drud/ddev-router:v0.4.3
commit:    	v0.7-44-gf1973c0
build info:	Built Mon Jul 10 19:24:56 PDT 2017 rfay@ubuntu drud/golang-build-container:v0.4.2

How to reproduce this:

Anything else do we need to know:

Related source links or issues:

@rickmanelius
Copy link
Contributor

Needs a confirm and then hopefully it's a quick fix. Thanks, @rfay!

@tannerjfco
Copy link
Contributor

I can reproduce the double-warning output on macOS. The double-warning is not intended, but the warning message shown for this state is valid and intended. With no sites running, there is no router, and no sites are accessible.

@rfay
Copy link
Member Author

rfay commented Jul 11, 2017

I guess I disagree about the router notification when there are only stopped sites. I would expect a reasonable user to understand that stopped sites are not accessible.

@rickmanelius
Copy link
Contributor

At a minimum, a double warning (even if it's benign) is going to be seen as an oddity to an end-user. If it's a simple LOE to address, my vote would be to correct this.

@rickmanelius
Copy link
Contributor

Not prioritized yet until we have reviewed the backlog.

@rfay rfay added actionable and removed hibernate labels Oct 31, 2017
rfay added a commit to rfay/ddev that referenced this issue Oct 31, 2017
@rfay
Copy link
Member Author

rfay commented Oct 31, 2017

I ran across this in #483 so fixed it there.

@rfay rfay closed this as completed in #483 Nov 2, 2017
rfay added a commit that referenced this issue Nov 2, 2017
…126, fixes #393 (#483)

* Basic port-test capabilities before trying to bring up router

* Add troubleshooting docs

* Remove double-notification about bad router, fixes #393
@rickmanelius rickmanelius added this to the v0.9.4 milestone Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants