New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Don't use third-party fonts from fonts.googleapis.com on ddev.readthedocs.io #4982
Comments
Moved to ddev.com-front-end |
@rfay I’m confused—why move this to the ddev.com project when it’s specifically about the docs? |
Just pretty confused I guess! Not thinking. I'll move it back. But I have no idea how we'd be using fonts unless it's an artifact of readthedocs? |
@gitressa would you mind poking around to figure out how the fonts are being pulled in? |
Sure @rfay, I found this:
This is the Material for MkDocs setting: Built-in privacy plugin. I see |
Want to try a PR? |
Great that you're open for this @rfay. I don't have time to look at it right now, but anyone else should feel free to create a PR in the meantime. |
OK @gitressa please reopen when you have time to look into it, thanks! |
I finally took stab at this @rfay. It ought to be as easy as adding two lines, which should install the privacy plug-in.
https://squidfunk.github.io/mkdocs-material/plugins/privacy/#configuration The test fails, though:
But ... you need to be a sponsor for this feature: https://squidfunk.github.io/mkdocs-material/insiders/ It's the heart icon, right below the title, which I understood after I found this: squidfunk/mkdocs-material#5317 (comment) |
Ah. We did sponsor and use the insiders version for a while, but it meant that ordinary users couldn't build the docs, so stopped, and went with the full open-source. |
We'd be happy to sponsor, but can't use something that requires one person's ssh key to be able to do a build. |
Thanks for clarifying @rfay. The next step in their fund raising is $14,000 – Goat's Horn where Privacy plugin will become available for everyone. Current funding is close at $13,860 a month, so perhaps DDEV could consider becoming a sponsor again? |
I need to review our upstream contributions, so will remember this. We can sponsor without using their too-hard-to-manage private build setup. Thanks! |
Sounds great, funding open source projects is important, as we all know :-) |
Great, thanks @rfay! If the key thing is still a problem, and since I don't know the details, would you consider creating an issue about it at https://github.com/squidfunk/mkdocs-material/issues? It might also help other projects to get this sorted out. |
The issue was discussed in |
Thanks, I have subscribed to that issue, and hope Insiders' workflow will be improved, or the goal of 14,000 reached, whatever comes first. |
I just checked, and the current funding is $14,720 a month (congratulations!) which should mean that the Built-in privacy plugin is now available to be enabled.
https://squidfunk.github.io/mkdocs-material/insiders/#14000-goats-horn |
A PR is welcome! |
Sure! It's here, and just need reopening: #5463. |
Is there an existing issue for this?
Problem
Respecting user privacy have been getting a lot of well deserved attention during the last few years. It is recommended to not use third-party fonts, to respect user privacy, and not hand over personal data to third-parties.
Steps To Reproduce
Solution
The text was updated successfully, but these errors were encountered: