Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gentler handling of removed directives and commands (omit_containers, --mutagen-enabled, --use-traefik) #5095

Closed
4 tasks done
gilbertsoft opened this issue Jul 6, 2023 · 1 comment
Assignees
Milestone

Comments

@gilbertsoft
Copy link
Member

gilbertsoft commented Jul 6, 2023

Expected Behavior

People expect old commands and directives to still work in v1.22.0:

  • omit_containers[dba] shouldn't create an error even if it's ignored. (project only, could give a message about deprecation)
  • --mutagen-enabled (global and project) could just set performance_mode: mutagen, maybe explain deprecated
  • --nfs-mount-enabled (global and project)
  • --use-traefik (global) can make sure that router: traefik

There may be a couple other things we should handle more gracefully

Actual Behavior

When using these currently users get errorrs.

ddev config --auto
You are reconfiguring the project at /home/simon/development/GsActions/commit-message-checker.
The existing configuration will be updated and replaced.
Configuring unrecognized codebase as project of type 'php' at /home/simon/development/GsActions/commit-message-checker
failed to validate config: unsupported omit_containers: [db dba ddev-ssh-agent], ddev (amd64) only supports the following for omit_containers: [db ddev-ssh-agent]

or

ddev start
Failed to get project(s): unsupported omit_containers: [db dba ddev-ssh-agent], ddev (amd64) only supports the following for omit_containers: [db ddev-ssh-agent]

Steps To Reproduce

No response

Anything else?

No response

@gilbertsoft gilbertsoft added this to the v1.22 milestone Jul 6, 2023
@rfay
Copy link
Member

rfay commented Jul 6, 2023

I wonder if we could just accept dba but remove it after loading.

@rfay rfay changed the title omit_containers is not properly migrated Gentler handling of removed directives and commands (omit_containers, --use-mutagen, --use-traefik) Jul 7, 2023
@rfay rfay changed the title Gentler handling of removed directives and commands (omit_containers, --use-mutagen, --use-traefik) Gentler handling of removed directives and commands (omit_containers, --mutagen-enabled, --use-traefik) Jul 7, 2023
@rfay rfay mentioned this issue Jul 7, 2023
28 tasks
@rfay rfay self-assigned this Jul 7, 2023
gilbertsoft added a commit to gilbertsoft/ddev that referenced this issue Jul 8, 2023
gilbertsoft added a commit to gilbertsoft/ddev that referenced this issue Jul 8, 2023
gilbertsoft added a commit to gilbertsoft/ddev that referenced this issue Jul 8, 2023
gilbertsoft added a commit to gilbertsoft/ddev that referenced this issue Jul 11, 2023
@rfay rfay closed this as completed in 4296999 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants