Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace go-amplitude fork with upstream now that blocking issue is resolved #5101

Closed
1 task done
marklabrecque opened this issue Jul 7, 2023 · 1 comment
Closed
1 task done

Replace go-amplitude fork with upstream now that blocking issue is resolved #5101

marklabrecque opened this issue Jul 7, 2023 · 1 comment
Labels
enhancement
Milestone
v1.22

Comments

@marklabrecque
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem?

See: amplitude/analytics-go#56 for a resolution.

It looks like we need to simply pull in v1.0.1 to shed the tech debt of the fork.

Describe your solution

Pull in the new version of the package, and remove the fork.

Describe alternatives

No response

Additional context

No response
@rfay rfay added this to the v1.22 milestone Jul 7, 2023
@rfay
Copy link
Member

rfay commented Jul 7, 2023

Awesome, go for it, thanks.

Followup is to archive the fork.

marklabrecque pushed a commit to marklabrecque/ddev that referenced this issue Jul 7, 2023
@marklabrecque-ab
ddev#5101: Remove amplitude fork from project in favour of upstream.
4851fb2
marklabrecque pushed a commit to marklabrecque/ddev that referenced this issue Jul 7, 2023
@marklabrecque-ab
ddev#5101: Remove forked amplitude in favor of upstream.
525d8ac
@rfay rfay mentioned this issue Jul 7, 2023
Merged
@rfay rfay closed this as completed in 8c5e0b0 Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.22
Development

No branches or pull requests
2 participants
@rfay @marklabrecque