Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the behavior of ddev config on an existing project with an invalid project type #5146

Closed
1 task done
rpkoller opened this issue Jul 15, 2023 · 0 comments
Closed
1 task done

Comments

@rpkoller
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem?

When switching back to the HEAD version from the silverstripe PR version i completely forgot for one project that it was created in silverstripe. I ran ddev configfor that project and the output was the following:

$> ddev config
You are reconfiguring the project at /Users/rkoller/Sites/craft3.
The existing configuration will be updated and replaced.
Project name (craft3): 

The docroot is the directory from which your site is served.
This is a relative path from your project root at /Users/rkoller/Sites/craft3
You may leave this value blank if your site files are in the project root
Docroot Location (public): 
Found a php codebase at /Users/rkoller/Sites/craft3/public.
Project Type [backdrop, craftcms, django4, drupal10, drupal6, drupal7, drupal8, drupal9, laravel, magento, magento2, php, python, shopware6, typo3, wordpress] (silverstripe):

i just pressed return accepting silverstripe. the output returned was:

'silverstripe' is not a valid project type. Allowed project types are: backdrop, craftcms, django4, drupal10, drupal6, drupal7, drupal8, drupal9, laravel, magento, magento2, php, python, shopware6, typo3, wordpress

Project Type [%s] (%s): backdrop, craftcms, django4, drupal10, drupal6, drupal7, drupal8, drupal9, laravel, magento, magento2, php, python, shopware6, typo3, wordpresssilverstripe

three problems first the output is twice. the first time correclt stating silverstripe is not a valid project type. the second time using Project Type [%s] (%s). the first time the last output is wordpress without silverstripe the second time the last output is wordpresssilverstripe and the cursor for text input is right after the eof silverstripe.
Screen Shot 2023-07-15 at 22 44 24

Describe your solution

After a none existing project type is submitted i would return:

[project type] is not a valid project type. 
Choose one of the following project types: [backdrop, craftcms, django4, drupal10, drupal6, drupal7, drupal8, drupal9, laravel, magento, magento2, php, python, shopware6, typo3, wordpress]: [cursor]

Describe alternatives

No response

Additional context

No response

@rfay rfay changed the title Improve the behavior of ddev config on an existing project with a none existent project type Improve the behavior of ddev config on an existing project with a nonexistent project type Jul 15, 2023
@rfay rfay changed the title Improve the behavior of ddev config on an existing project with a nonexistent project type Improve the behavior of ddev config on an existing project with an invalid project type Jul 15, 2023
@rfay rfay closed this as completed in 5afc743 Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant