Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting *.mysql file type for import-db #516

Closed
rfay opened this issue Oct 23, 2017 · 4 comments
Closed

Consider supporting *.mysql file type for import-db #516

rfay opened this issue Oct 23, 2017 · 4 comments
Assignees
Milestone

Comments

@rfay
Copy link
Member

rfay commented Oct 23, 2017

What happened (or feature request):

Rick noted with a ddev demo that an import of a backup-migrate module backup failed. For example, ddev import-db --src=APLVDatabaseBackup-2017-10-23T06-30-32.mysql.gz:

Failed to import database for aplv: no .sql files found to import

The issue here is that backup-migrate uses the very nonstandard ".mysql" file type inside the gzip file, and ddev recognizes only the more-likely ".sql" filetype.

backup-migrate has gzip files like APLVDatabaseBackup-2017-10-23T06-30-32.mysql.gz containing a file like APLVDatabaseBackup-2017-10-23T06-30-32.mysql. If you gunzip and give the .mysql file to ddev import-db, it imports just fine.

It shouldn't be hard to expand our vision to looking for *.mysql as equivalent to *.sql

@rfay rfay added the hibernate label Nov 20, 2017
@rickmanelius
Copy link
Contributor

We can re-open if anyone else trips up on this.

rfay added a commit to rfay/ddev that referenced this issue May 4, 2018
rfay added a commit to rfay/ddev that referenced this issue May 10, 2018
rfay added a commit to rfay/ddev that referenced this issue May 14, 2018
rfay added a commit to rfay/ddev that referenced this issue May 14, 2018
rfay added a commit that referenced this issue May 14, 2018
…ixes #516 (#824)

* Add test imports for .mysql files

* Support .mysql files for import along with related files, fixes #812, fixes #516
@dclear dclear removed the hibernate label May 31, 2018
@dclear dclear added this to the v0.19.0 milestone May 31, 2018
@nigelwhite
Copy link

As a frequent user of backup_migrate for its one-click downloads of remote databases (and I can't be the only one) this would be a big help.

@rfay
Copy link
Member Author

rfay commented Mar 5, 2019

Please open a new issue with your request, thanks!

@nigelwhite
Copy link

Done #1483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants