Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddev-router does not get proper label to identify it as owned by ddev, so ddev poweroff doesn't necessarily stop it #5542

Closed
rfay opened this issue Nov 16, 2023 · 0 comments
Closed

ddev-router does not get proper label to identify it as owned by ddev, so ddev poweroff doesn't necessarily stop it #5542

rfay opened this issue Nov 16, 2023 · 0 comments
Assignees
@stasadev
Milestone
v1.22.5

Comments

@rfay
Copy link
Member

rfay commented Nov 16, 2023 •
edited

The issue

ddev poweroff should always kill all ddev-created containers.

However, a dead ddev-router does not have the labels used to do that, so ddev poweroff can leave behind a dead router.

Demonstrated in
@rfay rfay changed the title ddev-router does not get proper label to identify it as owned by ddev ddev-router does not get proper label to identify it as owned by ddev, so ddev poweroff doesn't necessarily stop it Nov 16, 2023
@rfay rfay added this to the v1.22.5 milestone Nov 16, 2023
@stasadev stasadev mentioned this issue Nov 16, 2023
Merged
@rfay rfay closed this as completed in ca6b436 Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stasadev stasadev

Labels
None yet
Projects
None yet
Milestone
v1.22.5
Development

No branches or pull requests
2 participants
@rfay @stasadev