Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add label for ddev-router, fixes #5542 #5545

Merged
merged 1 commit into from Nov 18, 2023
Merged

fix: add label for ddev-router, fixes #5542 #5545

merged 1 commit into from Nov 18, 2023

Conversation

stasadev
Copy link
Member

The Issue

How This PR Solves The Issue

Adds a label, does a little reformatting of the router template.

Manual Testing Instructions

  1. ddev start
  2. docker inspect $(docker ps -f name=router -q) | jq '.[0].Config.Labels' check for com.ddev.site-name
  3. ddev poweroff

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner November 16, 2023 19:55
@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:

See Testing a PR

rfay
rfay approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, haven't tested. Not sure about the indentation changes.

@rfay rfay merged commit ca6b436 into ddev:master Nov 18, 2023
17 of 18 checks passed
@stasadev stasadev deleted the 20231116_stasadev_label_for_ddev-router branch November 20, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stasadev @rfay