Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.yaml: List of project types in comments is not up-to-date #5544

Closed
1 task done
ayacoo opened this issue Nov 16, 2023 · 5 comments
Closed
1 task done

config.yaml: List of project types in comments is not up-to-date #5544

ayacoo opened this issue Nov 16, 2023 · 5 comments

Comments

@ayacoo
Copy link
Contributor

ayacoo commented Nov 16, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Output of ddev debug test

No response

Expected Behavior

Is it probably too difficult to read out the project types dynamically?
I would simply extend the list and also refer to https://ddev.readthedocs.io/en/latest/users/quickstart/.

Actual Behavior

Just created a new project with 1.22.2. I noticed that the project types in the template are not up to date. See also list of hardcoded projecttypes: https://github.com/ddev/ddev/blob/master/pkg/ddevapp/templates.go#L10

Steps To Reproduce

Just create a new project with current ddev version

Anything else?

No response

@rfay
Copy link
Member

rfay commented Nov 16, 2023

Hi @ayacoo -

First, please use the current version of DDEV, which is v1.22.4. I'm not sure how you could "upgrade" to v1.22.2.

Second, not every recipe in the docs has a related project type. Project types in DDEV require quite a lot of testing and extra code, and not every project type needs that much handholding.

It's not possible at this time to "programmatically" use types from the docs, since that's a completely different thing. If you're interested in contributing a PR for a project type that is not currently explicitly supported, the info about how to do that is at https://ddev.readthedocs.io/en/latest/developers/project-types/

@ayacoo
Copy link
Contributor Author

ayacoo commented Nov 16, 2023

Hi @rfay,

I think we have misunderstood each other :-) I meant whether you can mention the existing projecttypes in the template, so that with "ddev config" the new projecttypes like drupal10 & co are also mentioned.

The list could of course be long. That's why I also wanted to add the links to the docs.

Before: # type: <projecttype> # drupal6/7/8, backdrop, typo3, wordpress, php
After: # type: <projecttype> # drupal6/7/8/9/10, backdrop, typo3, wordpress, php, craftcms, laravel, magento2, shopware6, silverstripe

Perhaps sort alphabetically as in the documentation?
(Sorry for the previous inaccurate explanation!)

@ayacoo ayacoo changed the title New project template: Projecttypes are not uptodate Template for new project: List of projecttypes are not uptodate Nov 16, 2023
@rfay
Copy link
Member

rfay commented Nov 16, 2023

Current DDEV has drupal 6/7/8/9/10. And has for a year or more.

If you're talking about "in the template" meaning in the config.yaml, you should do a ddev config --auto to update it. You probably have a .ddev/config.yaml that was created a really long time ago. DDEV doesn't touch that unless you do a ddev config.

Are you talking about docs, or are you talking about ddev config -h or are you talking about the comments in the project config.yaml?

@ayacoo
Copy link
Contributor Author

ayacoo commented Nov 16, 2023

I'm talking about the first generation of a project with ddev config. The following file is used there as the basis for the new project: https://github.com/ddev/ddev/blob/master/pkg/ddevapp/templates.go#L10

In line 10 you can see the comment. That's what I'm talking about :-)

(My config and ddev itself is now also on 1.22.4 ;-))

@rfay
Copy link
Member

rfay commented Nov 16, 2023

Please click the edit button on that page and create a PR. It's much easier than this conversation :)

@rfay rfay changed the title Template for new project: List of projecttypes are not uptodate config.yaml: List of project types in comments is not up-to-date Nov 18, 2023
@rfay rfay closed this as completed in 694c386 Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants