docs: Update list of project types in comments for config.yaml, fixes #5544 #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ayacoo
commented
Nov 16, 2023
•
ayacoo
commented
- config.yaml: List of project types in comments is not up-to-date #5544
ayacoo
changed the title
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
requested changes
Nov 16, 2023
pkg/ddevapp/templates.go
Outdated
| @@ -8,6 +8,8 @@ const ConfigInstructions = ` | |||
| # http://projectname.ddev.site and https://projectname.ddev.site | |||
|
|
|||
| # type: <projecttype> # drupal6/7/8, backdrop, typo3, wordpress, php, craftcms, laravel, magento2, shopware6, silverstripe | |||
There was a problem hiding this comment.
Suggested change
| # type: <projecttype> # drupal6/7/8, backdrop, typo3, wordpress, php, craftcms, laravel, magento2, shopware6, silverstripe | |
| # type: <projecttype> # drupal6/7/8/9/10, backdrop, typo3, wordpress, php, craftcms, laravel, magento2, shopware6, silverstripe |
rfay
reviewed
Nov 16, 2023
pkg/ddevapp/templates.go
Outdated
| # type: <projecttype> # drupal6/7/8, backdrop, typo3, wordpress, php | ||
| # type: <projecttype> # drupal6/7/8, backdrop, typo3, wordpress, php, craftcms, laravel, magento2, shopware6, silverstripe | ||
| # See https://ddev.readthedocs.io/en/latest/users/quickstart/ for more | ||
| # information on the different projecttypes |
There was a problem hiding this comment.
Suggested change
| # information on the different projecttypes | |
| # information on the different project types |
|
Firstly, thank you for your support :-) I was confused by the documentation here because project type "magento" was not mentioned there: https://ddev.readthedocs.io/en/latest/users/quickstart/#magento (tab "OpenMage/Magento 1") Django is tagged as "experimental". That's why I was unsure. I have taken the liberty of adopting your list, including alphabetical sorting. This is otherwise rather difficult to read |
rfay
changed the title
rfay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.