Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: autocompletions should not be added in /usr/bin for deb and rpm #5734

Closed
1 task done
stasadev opened this issue Jan 24, 2024 · 2 comments
Closed
1 task done

Comments

@stasadev
Copy link
Member

stasadev commented Jan 24, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Output of ddev debug test

Expand `ddev debug test` diagnostic information
[COPY-PASTE HERE THE OUTPUT OF `ddev debug test`]

Expected Behavior

The autocomplete scripts are already installed in /usr/share, where they belong.
/usr/bin for executables only.

Actual Behavior

ddev_bash_completion.sh, ddev_fish_completion.sh and ddev_zsh_completion.sh are added to /usr/bin folder for deb and rpm packages, and they are all executable, which adds to the confusion when trying to autocomplete ddev in your console.

See:

Steps To Reproduce

  1. Use Linux (or WSL2).
  2. Type ddev<TAB><TAB> in console
  3. See
$ ddev
ddev                     ddev_bash_completion.sh  ddev_zsh_completion.sh
ddev.link                ddev_fish_completion.sh

Anything else?

Noticed this in:

@rfay
Copy link
Member

rfay commented Jan 31, 2024

Is this a problem with goreleaser?

@stasadev
Copy link
Member Author

Yes, goreleaser builds all binaries for apt and rpm without filtering.

I believe #5759 might fix it, but I don't know how to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants