New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: filter binaries for deb and rpm on release, fixes #5734 #5759
build: filter binaries for deb and rpm on release, fixes #5734 #5759
Conversation
fa8d559
to
d942afa
Compare
Rebased. Picking up goreleaser fix for homebrew installs. |
d942afa
to
3c402e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fine after rebase, thanks!
3c402e3
to
789c79f
Compare
WalkthroughThis update introduces a Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Issue
How This PR Solves The Issue
Uses only
ddev
andmkcert
forbuilds
.From https://goreleaser.com/customization/nfpm/?h=nfpms
Manual Testing Instructions
Unpack deb and rpm to see what is inside
/usr/bin
https://github.com/ddev-test/ddev/releases/tag/v1.22.8-pr5759-deb-rpm-binaries
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes
Summary by CodeRabbit
ddev
andmkcert
in the release process.