Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: filter binaries for deb and rpm on release, fixes #5734 #5759

Merged

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Jan 31, 2024

The Issue

How This PR Solves The Issue

Uses only ddev and mkcert for builds.

From https://goreleaser.com/customization/nfpm/?h=nfpms

# Build IDs for the builds you want to create NFPM packages for.
# Defaults empty, which means no filtering.
builds:

Manual Testing Instructions

Unpack deb and rpm to see what is inside /usr/bin
https://github.com/ddev-test/ddev/releases/tag/v1.22.8-pr5759-deb-rpm-binaries

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Summary by CodeRabbit

  • New Features
    • Added new build targets for ddev and mkcert in the release process.

@rfay
Copy link
Member

rfay commented Feb 11, 2024

Rebased. Picking up goreleaser fix for homebrew installs.

@stasadev stasadev force-pushed the 20240131_stasadev_goreleaser_deb_rpm_binaries branch from d942afa to 3c402e3 Compare February 12, 2024 20:04
@stasadev stasadev marked this pull request as ready for review February 12, 2024 20:21
@stasadev stasadev requested review from a team as code owners February 12, 2024 20:21
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine after rebase, thanks!

@stasadev stasadev force-pushed the 20240131_stasadev_goreleaser_deb_rpm_binaries branch from 3c402e3 to 789c79f Compare February 13, 2024 11:35
Copy link

coderabbitai bot commented Feb 13, 2024

Walkthrough

This update introduces a builds section under nfpms in the .goreleaser.yml configuration file, specifically targeting ddev and mkcert as build options. This enhancement aims to streamline the packaging process for these applications, ensuring a smoother build and release workflow.

Changes

File Change Summary
.goreleaser.yml Added builds section under nfpms with ddev and mkcert as build targets.

🐰✨
In the realm of code, where changes abound,
A rabbit hopped in, with a soft thumping sound.
"Build targets added," it said with a cheer,
"For ddev and mkcert, let's make it clear!"
With a wiggle of nose and a flick of the ear,
The task was done, the path now steer.
🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 3f22d8f and 789c79f.
Files selected for processing (1)
  • .goreleaser.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .goreleaser.yml

@stasadev stasadev merged commit 3a1bcf9 into ddev:master Feb 13, 2024
11 checks passed
@stasadev stasadev deleted the 20240131_stasadev_goreleaser_deb_rpm_binaries branch February 13, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants