Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell completion file is a tar file but named as if it were tar.gz #5811

Closed
1 task done
HongPong opened this issue Feb 9, 2024 · 3 comments
Closed
1 task done

Shell completion file is a tar file but named as if it were tar.gz #5811

HongPong opened this issue Feb 9, 2024 · 3 comments

Comments

@HongPong
Copy link

HongPong commented Feb 9, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Output of ddev debug test

not related to ddev test but a distro release issue.

Expected Behavior

gzip expand the ddev_shell_completion_scripts.v1.22.7.tar.gz and install at /usr/local/bin for shell completions.

Actual Behavior

it says it is not a valid gzip file. when i use more it shows it is (at least mostly) plaintext file.

tar -zxf ddev_shell_completion_scripts.v1.22.7.tar.gz 
gzip: stdin: not in gzip format

The 1.22.6 file seems about identical as well

Steps To Reproduce

download the file and run gunzip or tar -zxf on it.

Actually the following does work, so the problem is the GZ not the TAR part - the file is a valid Tar but not a valid gzip and should be renamed accordingly:

tar -xvf ddev_shell_completion_scripts.v1.22.6.tar.gz
./
./ddev_fish_completion.sh
./ddev_fig_spec.ts
./ddev_zsh_completion.sh
./ddev_powershell_completion.ps1
./ddev_bash_completion.sh

Anything else?

No response

@rfay rfay changed the title Shell completion gzip file isn't valid / is a TAR but not a TAR.GZ Shell completion file is a tar file but named as if it were tar.gz Feb 9, 2024
@rfay
Copy link
Member

rfay commented Feb 9, 2024

I confirm this, thanks for reporting!

@HongPong
Copy link
Author

cool thanks @rfay this is literally the only glitch i've had in ages. much appreciate the tons of work on this thing.

@rfay
Copy link
Member

rfay commented Feb 10, 2024

We're working on shell completion in general in a couple of active issues, would love to have your feedback,

https://github.com/ddev/ddev/issues?q=is%3Aissue+is%3Aopen+autocompletion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants