Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DDEV got installed ("build: improve goreleaser, add testing capabilities, "head" release, …") #5830

Closed
gitressa opened this issue Feb 12, 2024 · 25 comments

Comments

@gitressa
Copy link
Contributor

gitressa commented Feb 12, 2024

I just got a new release offered, but it looks like maybe it wasn't planned? The title is "build: improve goreleaser, add testing capabilities, "head" release, …"

$ ddev start
You seem to have a new DDEV version. 
During an upgrade it's important to `ddev poweroff`.
May I do `ddev poweroff` before continuing?
This does no harm and loses no data. [Y/n] (yes): y
The ddev-ssh-agent container has been removed. When you start it again you will have to use 'ddev auth ssh' to provide key authentication again. 
Network ddev_default removed 
Starting drupal10... 
Network ddev_default created 
Network ddev-drupal10_default created 
20230818_bump_debian_bookworm: Pulling from ddev/ddev-webserver
e02d68a69f9c: Pull complete 
Digest: sha256:0017f77d8046ab81a4666addb56e0bbf14230c028b63f5f6b57d12634a59c212
Status: Downloaded newer image for ddev/ddev-webserver:20230818_bump_debian_bookworm
docker.io/ddev/ddev-webserver:20230818_bump_debian_bookworm
 Container ddev-ssh-agent  Created 
 Container ddev-ssh-agent  Started 
$ ddev version
 ITEM             VALUE                                             
 DDEV version     v1.22.7-12-g8c9ad1188                             
 architecture     amd64                                             
 db               ddev/ddev-dbserver-mariadb-10.4:v1.22.7           
 ddev-ssh-agent   ddev/ddev-ssh-agent:v1.22.7                       
 docker           25.0.3                                            
 docker-compose   v2.24.5                                           
 docker-platform  linux-docker                                      
 mutagen          0.17.2                                            
 os               linux                                             
 router           ddev/ddev-traefik-router:v1.22.7                  
 web              ddev/ddev-webserver:20230818_bump_debian_bookworm 
@rfay
Copy link
Member

rfay commented Feb 12, 2024

Thanks for subscribing to releases @gitressa !

We're all getting the same thing and we think we've figured out why. Will get it sorted.

@rfay rfay changed the title New release? ("build: improve goreleaser, add testing capabilities, "head" release, …") Too many notifications: New release? ("build: improve goreleaser, add testing capabilities, "head" release, …") Feb 12, 2024
@rfay rfay changed the title Too many notifications: New release? ("build: improve goreleaser, add testing capabilities, "head" release, …") Repeated email notifications: New release? ("build: improve goreleaser, add testing capabilities, "head" release, …") Feb 12, 2024
@rfay rfay pinned this issue Feb 12, 2024
@rfay
Copy link
Member

rfay commented Feb 12, 2024

  • there was a logic error in the workflow committed here
  • I think people who subscribe to releases will be annoyed by "head" releases for every commit to master anyway.
  • I think we should revert the "head" release feature and the minor doc that relates to it.
  • We also seem to have a bug in DDEV's new release detection where a release called "head" gets offered as a "new release", probably because it doesn't have a "-" in it for pre-release? But it shouldn't have offered a prerelease.

@gitressa
Copy link
Contributor Author

Thanks, but I am not subscribed to email notifications :) I simply got an update offered when I started DDEV, which I accepted ... Normally, it results in going from 1.22.6 to 1.22.7, but not this time.

@gitressa
Copy link
Contributor Author

It's #1 at the top of https://github.com/ddev/ddev/releases

@rfay
Copy link
Member

rfay commented Feb 12, 2024

That's because it's the most recent @gitressa

@rfay
Copy link
Member

rfay commented Feb 12, 2024

Thanks, but I am not subscribed to email notifications :) I simply got an update offered when I started DDEV, which I accepted ... Normally, it results in going from 1.22.6 to 1.22.7, but not this time.

Oh, DDEV offered it? It's a prerelease, so it should never be offered by DDEV itself. Can you show what you saw?

@gitressa
Copy link
Contributor Author

But ... why isn't it tagged with 1.22.8 then?

@gitressa
Copy link
Contributor Author

But I got it offered and it got installed. I put it right there in my issue :)

@rfay
Copy link
Member

rfay commented Feb 12, 2024

Thanks for reporting that. How did you install it? By downloading?

There was an enormous amount of chatter in Discord about the email notification problem about this release, so I just read your title and thought that was the whole deal.

I have deleted the "head" release and tag.

@gitressa
Copy link
Contributor Author

And to clarify, I have not set DDEV to get anything but stable releases, which is why I was really surprised to get a pre-release.

@rfay
Copy link
Member

rfay commented Feb 12, 2024

DDEV doesn't "get" anything. Can you say how you installed it?

@gitressa
Copy link
Contributor Author

I installed it with the standard Linux method: https://ddev.readthedocs.io/en/latest/users/install/ddev-installation/#linux

@gitressa gitressa changed the title Repeated email notifications: New release? ("build: improve goreleaser, add testing capabilities, "head" release, …") New DDEV got installed ("build: improve goreleaser, add testing capabilities, "head" release, …") Feb 12, 2024
@rfay
Copy link
Member

rfay commented Feb 12, 2024

So you're on Ubuntu, and you did an sudo apt-get update && sudo apt-get install -y?

@rfay
Copy link
Member

rfay commented Feb 12, 2024

I see that it got pushed inappropriately to the apt and yum repos, working on deleting it.

@gitressa
Copy link
Contributor Author

Great, thanks for confirming that there is an issue.

@rfay
Copy link
Member

rfay commented Feb 12, 2024

  • I deleted the errant apt/yum releases
  • I deleted the "head" release and tag
  • It didn't go to homebrew or the homebrew edge release
  • It didn't go to AUR

@rfay
Copy link
Member

rfay commented Feb 12, 2024

Anybody on Linux who got an inappropriate package installed should be able to fix it with

sudo apt update && sudo apt install ddev

@gitressa
Copy link
Contributor Author

Thanks @rfay, and sorry I left out the version when I created the issue. I was in a hurry, since I thought that the situation was a bit critical. Great that it got resolved.

I tried the command which made no difference ...

$ sudo apt update && sudo apt install ddev
Hit:2 https://mirror.netsite.dk/ubuntu/archive focal InRelease                                                                         
Hit:3 https://mirror.netsite.dk/ubuntu/archive focal-updates InRelease                                                                 
[...]
Reading state information... Done
ddev is already the newest version (1.22.8~8c9ad1188-head).
0 upgraded, 0 newly installed, 0 to remove and 4 not upgraded.

Though I am not sure if I got an inappropriate package?

$ ddev version
 ITEM             VALUE                                             
 DDEV version     v1.22.7-12-g8c9ad1188                             
 architecture     amd64                                             
 db               ddev/ddev-dbserver-mariadb-10.4:v1.22.7           
 ddev-ssh-agent   ddev/ddev-ssh-agent:v1.22.7                       
 docker           25.0.3                                            
 docker-compose   v2.24.5                                           
 docker-platform  linux-docker                                      
 mutagen          0.17.2                                            
 os               linux                                             
 router           ddev/ddev-traefik-router:v1.22.7                  
 web              ddev/ddev-webserver:20230818_bump_debian_bookworm 

@gitressa
Copy link
Contributor Author

It's odd, APT says 1.22.8~8c9ad1188-head, but DDEV says v1.22.7-12-g8c9ad1188.

@gitressa
Copy link
Contributor Author

Docker says:

$ docker ps --all
CONTAINER ID   IMAGE                               COMMAND                 CREATED         STATUS                   PORTS     NAMES
899bf4cfa978   ddev/ddev-ssh-agent:v1.22.7-built   "/entry.sh ssh-agent"   5 minutes ago   Up 5 minutes (healthy)             ddev-ssh-agent

@gitressa
Copy link
Contributor Author

$ sudo apt list --installed | grep ddev
WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
ddev/now 1.22.8~8c9ad1188-head amd64 [installed,local]

Also, I note that 8c9ad1188 is part of both APT and DDEV version

$ ddev version
 ITEM             VALUE                                             
 DDEV version     v1.22.7-12-g8c9ad1188  
[...]

@rfay
Copy link
Member

rfay commented Feb 12, 2024

You'll want to remove and reinstall, please try that, thanks. sudo apt update && sudo apt remove ddev && sudo apt install -y ddev

@gitressa
Copy link
Contributor Author

Thanks, all is well now :)

$ ddev version
 ITEM             VALUE
 DDEV version     v1.22.7
[...]

@rfay
Copy link
Member

rfay commented Feb 12, 2024

Sorry for the trouble! Cascading series of bugs!

@gitressa
Copy link
Contributor Author

Heh, no problem! I am very grateful for the wonderful tool that DDEV is, and how you guys maintain it so well, and expand it with features continually. A very small hiccup like this is to be expected with all the development going on :)

@rfay rfay unpinned this issue Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants