Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify the user when a ddev update is available as the last item in output #5889

Open
1 task done
gilzow opened this issue Feb 23, 2024 · 7 comments
Open
1 task done

Comments

@gilzow
Copy link
Collaborator

gilzow commented Feb 23, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem?

I can spend hours trying to debug a ddev-related issue only to discover there's an update for ddev that solves the issue.

Describe your solution

Have DDEV notify users of DDEV updates on a more regular basis (daily, every use) and have the message be the last thing output to the user.

Describe alternatives

No response

Additional context

As someone who only occasionally works on projects where DDEV is a suitable local development tool, it can be months between when I use it. As I understand it, DDEV does not inform users of an update per-use but once a week (or month?). It also appears to be the very first message (or very early) once ddev begins its process (e.g. outputting after walking through the interactivity for ddev config). Given the large amount of DDEV sends to stdout during its rouines, it is very easy to miss the message before it scrolls out of view. Combine that with only notifying users once a week (month), it is very easy for users to miss the notification.

@rfay
Copy link
Member

rfay commented Feb 23, 2024

Thanks!

@rfay
Copy link
Member

rfay commented Feb 25, 2024

I guess we could notify BOTH at the beginning of output AND at the end :)

@rfay
Copy link
Member

rfay commented Feb 28, 2024

What do you think about a sleep after the notification @gilzow ? Show the upgrade notice and say "waiting 5 second for you to see this..." ??? I've seen that in similar situations on other products.

@chrisfromredfin
Copy link
Collaborator

I think at the top is more "standard" so I tend to lean toward a small delay after showing it, and maybe keeping the pester interval at about a day? Just my $0.02.

@tyler36
Copy link
Collaborator

tyler36 commented Feb 29, 2024

Show the upgrade notice and say "waiting 5 second for you to see this..."

Deliberately slowing down the user experience is not good.
This would be annoying if things like the DrupalPod image were slow to update.

What about a message on ddev stop / ddev powerdown ?

@rfay
Copy link
Member

rfay commented Feb 29, 2024

Recently the nodejs installation technique changed, https://github.com/nodesource/distributions?tab=readme-ov-file#debian-versions - deb.nodesource.com started delaying 30 SECONDS to insist that you got a message about their changes. But of course... it was all automated inside a Dockerfile build, so I didn't see it for weeks or months :)

@rfay
Copy link
Member

rfay commented Feb 29, 2024

We could add a dont_pester_me_about_updates config option :)
Or "press enter to continue without waiting"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants