Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Using nginx snippets" notification could have improved formatting #5985

Closed
1 task done
diegoe opened this issue Mar 18, 2024 · 1 comment · Fixed by #6030
Closed
1 task done

"Using nginx snippets" notification could have improved formatting #5985

diegoe opened this issue Mar 18, 2024 · 1 comment · Fixed by #6030

Comments

@diegoe
Copy link
Contributor

diegoe commented Mar 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Output of ddev debug test

NA

Expected Behavior

ddev could report nginx snippets in a more readable fashion (?):

Using nginx snippets: [
  /Users/diego/some-project/.ddev/nginx/some.conf,
  /Users/diego/some-project/.ddev/nginx/some-other.conf
]
Custom configuration, including snippets, is only updated on project restart.
Run `ddev restart` if you do not see your configuration in effect.

Of course, the above could be smarter about other snippets or servers. I'm not familiar with other setups.

Actual Behavior

ddev reports nginx snippets like:

Using nginx snippets: [/Users/diego/some-project/.ddev/nginx/some.conf /Users/diego/some-project/.ddev/nginx/some-other.conf]
Custom configuration is updated on restart.
If you don't see your custom configuration taking effect, run 'ddev restart'.

Steps To Reproduce

  1. Use a snippet in .ddev/nginx
  2. Restart the project
  3. Message is printed in hard to read format

Anything else?

See: https://github.com/ddev/ddev/blob/master/pkg/ddevapp/config.go#L613

@rfay
Copy link
Member

rfay commented Mar 18, 2024

A PR is welcome. Snippets are little-used and were scheduled for removal, but people liked them so they're still around.

If you aren't interested in doing a PR I doubt this will be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants