Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circleci test failures (apparently in waiting for project to come up) #837

Closed
rfay opened this issue May 9, 2018 · 1 comment
Closed
Assignees
Milestone

Comments

@rfay
Copy link
Member

rfay commented May 9, 2018

What happened (or feature request):

We have regular test failures, apparently waiting for containers to become ready, which result in test timeouts and horrible huge stack traces. See https://circleci.com/gh/rfay/ddev/368?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Taking a look at the stack traces, this seems to happen in TestDescribe and TestRouterPortsCheck quite a lot.

Theories:

  • The wait for container is too complex and can be simplified?
  • We're running too many sites at once and should be turning them down after bringing them up?

What you expected to happen:

How to reproduce this:

Version: Please include the output of ddev version, docker version and the project's .ddev/config.yaml.

Anything else do we need to know:

Related source links or issues:

Please use a complexity rating of 1-5 (5 is high) for a feature request. (High complexity implies more PR planning)

@rfay
Copy link
Member Author

rfay commented May 10, 2018

I think there are probably two levels of failure here.

  1. Site is not coming up. May be that we're using too many resources or...
  2. EnsureHTTPStatus() is way more complex that it needs to be (there's a much simpler golang paradigm). The result is a huge (and late) failure.

This just needs some love, and probably needs some love pretty soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants