Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting environment variables directly from config.yaml #871

Closed
rfay opened this issue May 22, 2018 · 1 comment
Closed

Support setting environment variables directly from config.yaml #871

rfay opened this issue May 22, 2018 · 1 comment
Labels
Prioritized We expect to do this in an upcoming release

Comments

@rfay
Copy link
Member

rfay commented May 22, 2018

Is your feature request related to a problem? Please describe.

TYPO3 uses environment variables (in php) for various uses that are important to development, especially TYPO3_CONTEXT=Development.

We have various ways to set these but they're pretty twiddly. See https://stackoverflow.com/questions/50109020/how-can-i-set-environment-variables-inside-ddevs-containers and https://stackoverflow.com/questions/49997842/how-to-set-typo3-context-in-ddev

Describe the solution you'd like

Add environment variable spec to config.yaml:

environment:
  web:
    - WEBVAR1=value1
    - WEBVAR2=value2:
  db:
    - DBVAR1=value1

Related PR that does this in a more complicated way: #870

Note: After this is addressed the related Stack Overflow articles should be addressed.

@rfay
Copy link
Member Author

rfay commented May 22, 2018

I think the best way to do this is with Stop use of environment variables to communicate with docker-compose. Instead of templating, we'll use a structure that gets marshalled as the docker-compose.yaml. This is not too difficult, but requires changes in a number of places; all data will be included directly in the docker-compose. It will be a really good refactoring I think.

@rfay rfay added the Prioritized We expect to do this in an upcoming release label Jun 29, 2019
@rfay rfay added this to the v1.17 milestone Nov 8, 2020
rfay added a commit to rfay/ddev that referenced this issue Jan 11, 2021
@rfay rfay closed this as completed in 1d9931f Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prioritized We expect to do this in an upcoming release
Projects
None yet
Development

No branches or pull requests

1 participant