Remove Dockerfile.in instances, obsolete now with latest build-tools #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfrench
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
With the introduction of the latest build-tools, Dockerfile.in was deprecated, but I left both Dockerfile and Dockerfile.in in a couple of directories. Must die.
How this PR Solves The Problem:
Remove extra Dockerfile.in
I checked with a diff and Dockerfile.in and Dockerfile were identical in each of these directories.
Manual Testing Instructions:
If this passes nightly build and container builds, we should be fine.
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: