Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to remove running projects before testing #1013

Merged

Conversation

andrewfrench
Copy link
Contributor

The Problem/Issue/Bug:

Local tests fail all the time because projects are already running.

How this PR Solves The Problem:

Non-destructively remove running projects before beginning tests by attempting to call ddev remove --all.

If a system doesn't have ddev in its $PATH (CircleCI), the command will fail and emit a warning message, but it will not fail the test.

Manual Testing Instructions:

  • Manually start a few projects
  • make test
  • TestMain will remove running projects before testing and not fail immediately

@andrewfrench andrewfrench added this to the v1.1.0 milestone Jul 25, 2018
@andrewfrench andrewfrench self-assigned this Jul 25, 2018
@andrewfrench andrewfrench requested a review from rfay July 25, 2018 16:02
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tried it out in both cmd and pkg and it worked great. Took us more than a year to think of this? I guess --all is what made it all possible!

@andrewfrench andrewfrench merged commit ccaa5d3 into ddev:master Jul 25, 2018
@andrewfrench andrewfrench deleted the 2018-07-25_cleanup-before-tests branch July 25, 2018 17:29
@dclear dclear removed the actionable label Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants