Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locales to web container, fixes #822 #1106

Merged
merged 1 commit into from Sep 18, 2018
Merged

Conversation

rfay
Copy link
Member

@rfay rfay commented Sep 13, 2018

The Problem/Issue/Bug:

in #822 a couple of users have requested locales be installed in the web container. It's easy enough to add that package locales-all

How this PR Solves The Problem:

Add locales-all

Manual Testing Instructions:

  • Edit .ddev/config.yaml to use webimage: drud/ddev-webserver:20180913_locales
  • Add the LANG environment variable with a docker-compose.env.yaml as shown below (example, uses de_DE.iso88591)
  • ddev start
  • ddev ssh to visit the web container

Example .ddev/docker-compose.env.yaml:

version: '3.6'

services:
  web:
    environment:
      - LANG=de_DE.iso88591
`

@rfay
Copy link
Member Author

rfay commented Sep 14, 2018

I wish it didn't, but this does add 28MB to that container, a pretty big hit for a fairly small gain. I wonder if there are smaller solutions.

drud_ddev-webserver_-_docker_hub

@sbaghdadi
Copy link

sbaghdadi commented Sep 17, 2018

I can confirm that this change works. I tested on mac osx 10.12.04 with ddev 1.1.1 . See Screenshot attached.

bildschirmfoto 2018-09-17 um 10 00 39

I also want to add, that this not set a correct date in the ddev container.

bildschirmfoto 2018-09-17 um 10 00 52

If you want to have the correct date and time you also have to add the TZ in environments. Example:

version: '3.6'

services:
  web:
    environment:
      - LANG=de_DE.iso88591
      - TZ=Europe/Berlin

bildschirmfoto 2018-09-17 um 10 03 21

Copy link

@sbaghdadi sbaghdadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on MacOSx 10.12.04 and ddev 1.1.1

@rfay
Copy link
Member Author

rfay commented Sep 17, 2018

Thanks for the testing! Getting TZ is documented in https://stackoverflow.com/questions/50255466/how-can-i-set-the-timezone-in-my-ddev-containers - I wish I'd come up with an easier way, maybe will revisit. Don't think it's much related to this though.

@rfay
Copy link
Member Author

rfay commented Sep 17, 2018

The thing that makes TZ hard is it's not easily accessible on macOS. Explored in #709

@rfay rfay merged commit b992f6f into ddev:master Sep 18, 2018
@rfay rfay deleted the 20180913_locales branch October 9, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants