New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locales to web container, fixes #822 #1106
Conversation
I can confirm that this change works. I tested on mac osx 10.12.04 with ddev 1.1.1 . See Screenshot attached. I also want to add, that this not set a correct date in the ddev container. If you want to have the correct date and time you also have to add the TZ in environments. Example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on MacOSx 10.12.04 and ddev 1.1.1
Thanks for the testing! Getting TZ is documented in https://stackoverflow.com/questions/50255466/how-can-i-set-the-timezone-in-my-ddev-containers - I wish I'd come up with an easier way, maybe will revisit. Don't think it's much related to this though. |
The thing that makes TZ hard is it's not easily accessible on macOS. Explored in #709 |
c6c58bb
to
76c67a7
Compare
The Problem/Issue/Bug:
in #822 a couple of users have requested locales be installed in the web container. It's easy enough to add that package locales-all
How this PR Solves The Problem:
Add locales-all
Manual Testing Instructions:
webimage: drud/ddev-webserver:20180913_locales
ddev ssh
to visit the web containerExample .ddev/docker-compose.env.yaml: