Use command instead of which in install script, fixes #1114 #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20180920_fix_install_script
branch
from
ef78a2e
to
dca3ee3
Compare
andrewfrench
approved these changes
Sep 24, 2018
rfay
force-pushed
the
20180920_fix_install_script
branch
from
dca3ee3
to
7f609a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
#1114 points out that the output of "which" in the install script is shown to the user (although the script works fine).
How this PR Solves The Problem:
curl -L, so it follows redirects.Manual Testing Instructions:
Run the install script as in the Linux or macOS install section
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: