Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset disable_functions in php config, fixes #1127 #1130

Merged
merged 2 commits into from Oct 2, 2018

Conversation

rfay
Copy link
Member

@rfay rfay commented Sep 25, 2018

The Problem/Issue/Bug:

OP #1127 reports that drush php doesn't work as expected, due to aggressive (server-expected) disable_functions in our php config.

How this PR Solves The Problem:

Turns off the disable_functions in php config

Manual Testing Instructions:

On a d8 project,

  • make sure you have done a composer require drush/drush (so you have a local drush 9)
  • Use webimage: drud/ddev-webserver: 20180925_php_ini_disable_functions in your config.yaml
  • ddev start
  • ddev ssh
  • drush version should show 9.4
  • drush php
  • You should be able to do interactive php commands like echo "hi there"; and php should execute and return without errors.

Automated Testing Overview:

Related Issue Link(s):

OP #1127

Release/Deployment notes:

@rfay rfay added this to the v1.3.0 milestone Sep 25, 2018
@rfay rfay self-assigned this Sep 25, 2018
Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running through the manual review steps, all looks good.

  • composer require drush/drush
  • Update config.yaml to webimage: drud/ddev-webserver:20180925_php_ini_disable_functions
  • ddev start
  • ddev ssh
  • drush version => 9.4.0
  • drush php
  • echo "ahoy"; => ahoy

@rfay rfay force-pushed the 20180925_php_ini_disable_functions branch from bd42f5b to 9e28eaf Compare October 1, 2018 17:56
@rfay rfay force-pushed the 20180925_php_ini_disable_functions branch from 9e28eaf to 38a7925 Compare October 1, 2018 22:11
@rfay rfay merged commit 95eabc0 into ddev:master Oct 2, 2018
@rfay rfay deleted the 20180925_php_ini_disable_functions branch October 2, 2018 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants