Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mysqld to output to stderr, fixes #1136 #1141

Merged
merged 3 commits into from Oct 2, 2018

Conversation

rfay
Copy link
Member

@rfay rfay commented Sep 29, 2018

The Problem/Issue/Bug:

OP #1136 - it was really hard to figure out what would go wrong with mysqld when something was wrong. You had to capture the container, then docker exec into it, then view the logs.

How this PR Solves The Problem:

  • mysqld logs now land in stderr, which means they're captured by ddev logs -s db
  • Update docs that incorrectly stated that the logs were captured in files inside the container.

Manual Testing Instructions:

  • Start a project
  • ddev logs -s db to view the full startup of the container.

For extra credit, break the thing:

  • ddev ssh -s db
  • rm /var/lib/mysql/mysql/*.MYD
  • ddev rm && ddev start. It won't come up.
  • ddev logs -s db to find out what's wrong.

Automated Testing Overview:

No tests were added.

Related Issue Link(s):

OP #1136

@rfay rfay added this to the v1.3.0 milestone Sep 29, 2018
@rfay rfay self-assigned this Sep 29, 2018
Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ddev logs -s db shows detailed mysql logs, especially useful when the db service is broken. Works as expected 👍

@rfay rfay merged commit 19063c0 into ddev:master Oct 2, 2018
@rfay rfay deleted the 20180929_mariadb_stderr branch October 2, 2018 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants