Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop warning about non-config files in ddev start, fixes #731 #1143

Merged
merged 3 commits into from Oct 9, 2018

Conversation

rfay
Copy link
Member

@rfay rfay commented Sep 29, 2018

The Problem/Issue/Bug:

Previously we were warning about non-config files (anything in a directory) when warning about mysql and php config.

Also there was no warning about apache config overrides.

How this PR Solves The Problem:

  • Use a glob to only warn about files which are actually config overrides.
  • Add output for apache overrides.

Manual Testing Instructions:

  • Create config overrides (nginx, apache, mysql, php)
  • Put things in those directories which are not config overrides.
  • Verify that only legitimately named override files are reported.
  • nginx config should only be reported for webserver_type=nginx-fpm, converse for apache config.

Automated Testing Overview:

No new tests

Related Issue Link(s):

OP #731

@rfay rfay added this to the v1.3.0 milestone Sep 29, 2018
@rfay rfay self-assigned this Sep 29, 2018
@rfay rfay force-pushed the 20180929_dont_tell_about_non_ini branch 2 times, most recently from 31fc29b to bf4b294 Compare October 6, 2018 23:43
Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With ddev version (and on Windows):

web   	drud/ddev-webserver:20181002_sqlite             
db    	drud/ddev-dbserver:20180929_mariadb_stderr      
dba   	drud/phpmyadmin:v1.2.0                          
router	drud/ddev-router:20180922_upgrade_debian_stretch
commit	v1.2.0-29-gbf4b294a                             
domain	ddev.local                                      
cli   	v1.2.0-29-gbf4b294a                             
  • Create .ddev/mysql/mysql.cnf
  • Create .ddev/apache/apache-site.conf
  • Create .ddev/php/php.ini
  • Create .ddev/nginx-site.conf
  • ddev start
  • By default (using nginx), the nginx, php, and mysql warnings are written to the terminal
  • Change server type to apache-cgi
  • ddev start
  • Using apache, the apache, php, and mysql warnings are written to the terminal

@rfay rfay force-pushed the 20180929_dont_tell_about_non_ini branch from bf4b294 to 651b288 Compare October 9, 2018 13:23
@rfay rfay force-pushed the 20180929_dont_tell_about_non_ini branch from 651b288 to d6e7681 Compare October 9, 2018 15:54
@rfay rfay merged commit f83954a into ddev:master Oct 9, 2018
@rfay rfay deleted the 20180929_dont_tell_about_non_ini branch October 9, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants