Improve reliability of TestDevLogs (in cmd) #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
commented
Oct 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
We see regular failures of TestDevLogs (in cmd) like this in buildkite - basically a million warnings like
[29-Sep-2018 22:22:36] WARNING: [pool www] child 488 said into stderr: "NOTICE: PHP message: PHP Warning: Unexpected character in input: ' in /var/www/html/htdocs/index.php on line 1"which (seem?) to flood the item we're looking at, so the test fails. It's intermittent, so hard to chase.How this PR Solves The Problem:
Simplify the test, use some of our newer tools (testcommon.GetLocalHTTPResponse()), and use a static fatal.php instead of writing it out.
Manual Testing Instructions:
Probably if it tests OK then it's not going to be any worse.