Validate the project name when it's entered, fixes #514, fixes #86 #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
changed the title
rfay
force-pushed
the
20180929_validate_projectname
branch
2 times, most recently
from
a7cea6f
to
b9cac94
Compare
rfay
force-pushed
the
20180929_validate_projectname
branch
from
b9cac94
to
9a29efa
Compare
andrewfrench
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
OP #514 - It's a standard problem new users have that they will enter a project name like "my project", which spaces or other problems that result in an invalid url.
We should finally validate it.
#86 also requests sanitization of hostnames; however this PR merely insists that the user choose an appropriate hostname.
How this PR Solves The Problem:
The project name is validated at the point of request. If it doesn't work, a correct project name is insisted on.
Manual Testing Instructions:
ddev configwith invalid hostnames like "an invalid hostname" or "an_invalid_hostname".ddev configin a directory which would be invalidddev config --projectname="invalid hostname"etcAutomated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: