Add php*-sqlite3 to web container #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
changed the title
rfay
commented
Oct 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
sqlite3 is occasionally requested. Some of our best contributors and users have requested it.
How this PR Solves The Problem:
Add it with a new image. Note that any user can do this with post-start hooks.
This seems to add only about 1MB to the image size.
Manual Testing Instructions:
Use
webimage: drud/ddev-webserver:20181002_sqlitein .ddev/config.yaml andddev start.Try configuring a ddev project with sqlite3 db; this will require overriding the ddev generated settings.
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: