Improve TestWebserverType() #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20181004_server_header
branch
from
365e938
to
edc6c0a
Compare
rfay
force-pushed
the
20181004_server_header
branch
from
edc6c0a
to
000b5c7
Compare
andrewfrench
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
In #1148 (Adding TestWebserverType() to test to make sure we get the type of webserver we're expecting), I was stuck on the fact that the "Server" header was always nginx, so didn't do everything in the test I wanted. Of course the Server header was always nginx, because that's what the router runs. Anyway, I wanted to test for the Server header!
How this PR Solves The Problem:
This PR uses the direct-to-web-container approach and can check for the Server header coming directly from the web container.
It also does minor refactoring to provide easy access to the local-direct URL and port; those were previously done in inline code in app.Describe().
Manual Testing Instructions:
I think if you like the code and it passes that's good enough.
Automated Testing Overview:
This improves TestWebserverType()
Related Issue Link(s):
Release/Deployment notes: