New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly support mariadb upgrade from 10.1 to 10.2 #1160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20181006_mariadb_upgrade
branch
from
October 9, 2018 01:45
496c3ab
to
22bb278
Compare
andrewfrench
approved these changes
Oct 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ran through the manual steps, everything looks good:
(with ddev version 1.2.0)
ddev start
- Install site to populate database
ddev rm
(with ddev v1.2.0-37-g22bb278c)
ddev start
ddev logs -s db
contains "Running mysql_upgrade"ddev snapshot
ddev rm
ddev start
ddev logs -s db
does not contain "Running mysql_upgrade"ddev restore-snapshot <snapshot>
ddev logs -s db
does not contain "Running mysql_upgrade"
Thanks for the review @andrewfrench . I'm going to do one more little bit with this, detect when we can't restore a snapshot and give them a link to the workaround. |
rfay
force-pushed
the
20181006_mariadb_upgrade
branch
from
October 9, 2018 16:43
503bae3
to
f936936
Compare
…_db updates mariadb version
rfay
force-pushed
the
20181006_mariadb_upgrade
branch
from
October 9, 2018 17:58
f936936
to
4619193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
We incidentally upgraded mariadb from 10.1 to 10.2 when upgrading the container in #1123
However, you need to run
mysql_upgrade
when you do that. So we need to run mysql_upgrade on existing databases when they come up.How this PR Solves The Problem:
mysql_upgrade
Manual Testing Instructions:
drud/ddev-dbserver:v1.2.0
in config.yaml; it seems to be compatible.ddev rm
dbimage: drud/ddev-dbserver:20181006_mariadb_upgrade
in config.yamlddev logs
should show no errors, and you should see in there "Running mysql_upgrade" and a successful run.ddev rm
ddev start
ddev logs -s db
. You should not see the mysql_upgrade, and should not see errors.ddev logs -s db
. You should not see the "Running mysql_upgrade"Test bind-migration workflow:
ddev start
Consider testing restore-snapshot with old snapshot
Automated Testing Overview:
Related Issue Link(s):
The mariadb upgrade happened in #1123
Release/Deployment notes:
SUPER IMPORTANT: Unfortunately,
webimage: drud/ddev-dbserver:v1.2.0
in .ddev/config.yamlddev start
ddev restore-snapshot <name>
ddev rm
ddev start
This PR links people to what to do.