Only run post-start hook when the new container is actually created, fixes #1115 #1298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
People who put post-start hooks in really normally want them to run only when the container is created or recreated. A common example is installing an extra Debian package; it only needs to be done when the container is recreated. A start that doesn't recreate doesn't need to run the hook. OP #1115
How this PR Solves The Problem:
Manual Testing Instructions:
ddev start
. You should see it fireddev start
again, you should not see it fireddev start
, container should be recreated and you should see it fire.Automated Testing Overview:
Related Issue Link(s):
OP #1115
Release/Deployment notes:
This does in fact change the behavior of the post-start hook, so needs to be announced. Most people will like it, it's probably more what's expected.