Make sure that TestConfigOverrideDetection cleans up after itself, for #1270 #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
changed the title
andrewfrench
approved these changes
Nov 26, 2018
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
In #1270 (intermittent and annoying test failures) we note that TestConfigOverrideDetection regularly breaks itself and other things by not cleaning up its containers. The lack of cleanup was a result of a require, which when failing, missed the app.Down().
How this PR Solves The Problem:
Use a defer app.Down()
Manual Testing Instructions:
Not possible as far as I know.
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: