Use mysqli in db_url for Drupal 6, fixes #1325 #1328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
OP#1372 points out that our standard drupal 6 config in settings.ddev.php uses the mysql:// db_url, but php 7.2 with D6LTS wants the mysqli:// db_url.
How this PR Solves The Problem:
This just changes "mysql://" to "mysqli://" in Drupal6 settings.ddev.php. It doesn't seem to affect traditional Drupal 6 configuration.
Manual Testing Instructions:
Details about php-mbstring.
Note that there is a problem with D6LTS that I don't totally understand at install time. It insists:
However, in our post-php-5.6 configurations we do not have mbstring.http_output set:
However, you can import a d6 db and it lets you walk past this problem.
Automated Testing Overview:
Related Issue Link(s):
OP #1325
Release/Deployment notes: