Regression: docker and docker-compose versions empty in ddev version
#1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/version/version.go
Outdated
| versionInfo["docker"] = DockerVersion | ||
| versionInfo["docker-compose"] = DockerComposeVersion | ||
| if versionInfo["docker"], err = GetDockerVersion(); err != nil { | ||
| _ = fmt.Errorf("failed to GetDockerVersion(): %v", err) |
There was a problem hiding this comment.
These error values are formatted, but never returned.
rfay
force-pushed
the
20181214_fix_version_dockerinfo
branch
from
78d5b28
to
a2ee615
Compare
andrewfrench
approved these changes
Dec 14, 2018
rfay
force-pushed
the
20181214_fix_version_dockerinfo
branch
from
a2ee615
to
0efcdee
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
I noted that
ddev versionhad empty lines for docker and docker-compose versions (recently added).How this PR Solves The Problem:
Use the getter for them instead of using the variable directly.
Sad dance to resolve import cycles. Our packages are kind of out of control.
Manual Testing Instructions:
Use
ddev versionAutomated Testing Overview:
Added trivial stuff in the related test functions.
Related Issue Link(s):
Release/Deployment notes: