Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webcache deprecation, fixes #1495 #1530

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Conversation

rfay
Copy link
Member

@rfay rfay commented Apr 10, 2019

The Problem/Issue/Bug:

We're no longer supporting the experimental webcache feature (macOS only)

How this PR Solves The Problem:

  • Make it less obtrusive in the config.yaml (don't show it unless it's turned on)
  • Add minor docs about it in the comment section of config.yaml
  • Turn off webcache-specific testing except for the one TestWebcache test.
  • Make clear in docs (readthedocs) that it's deprecated and what it might be used for.

Manual Testing Instructions:

Related Issue Link(s):

OP #1495
@kaystrobach's #1528 PR

Release/Deployment notes:

@rfay rfay added this to the v1.8.0 milestone Apr 10, 2019
@rfay rfay self-assigned this Apr 10, 2019
@rfay rfay merged commit 34c84c7 into ddev:master Apr 15, 2019
@rfay rfay deleted the 20190410_deprecate_webcache branch April 15, 2019 18:09
@rfay rfay mentioned this pull request May 9, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant