SetSiteSettingsPaths() has to be set after we've read the config, fixes #1553 #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20190429_fix_drush_config
branch
from
e7fa813
to
c4eb6c1
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
OP #1553 points out that the ddev_drush_settings.php is getting created in the projectroot instead of in the settings directory.
This turns out to be a side-effect of default project creation, the project type was being set after the site settings file was derived.
How this PR Solves The Problem:
Manual Testing Instructions:
ddev startYou should be able to
drush sql-clisuccessfully if you have a drush8 on the host.Or just verify that ddev_drush_settings.php got created in the (Drupal) sites/default
Automated Testing Overview:
Added simplistic test coverage for the settings location and the ddev_drush_settings.php in TestDdevFullSiteSetup
Related Issue Link(s):
OP #1553