-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker-compose build for dynamic containers, allow easier container config #1560
Use docker-compose build for dynamic containers, allow easier container config #1560
Conversation
fc915fc
to
99b499e
Compare
23d1fed
to
a04396f
Compare
a04396f
to
01f108d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very interesting, and I expect this will be used as a more robust replacement for complex pre-start hook configurations? I think it's a great and pretty powerful idea and I'm interested in seeing how people end up using this.
While testing, I confirmed that I could define a Dockerfile used to extend both the ddev-webserver and ddev-dbserver containers, build them on start, and confirm that the customizations made in the custom Dockerfile were present in the container using ddev ssh
.
d3d75c7
to
6f51787
Compare
The Problem/Issue/Bug:
How this PR Solves The Problem:
webimage_extra_packages
anddbimage_extra_packages
allow just adding debian packages without writing a Dockerfile.TODO:
Manual Testing Instructions:
ddev start
You should find on
ddev ssh
that php7.3-yaml is installedDo the same thing for db-build (with a different package or action)
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: