Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddev exec command should allow tty interactions #1571

Merged
merged 2 commits into from
May 7, 2019

Conversation

rfay
Copy link
Member

@rfay rfay commented May 6, 2019

The Problem/Issue/Bug:

People have long been frustrated by the inability to interact with the console using ddev exec. But we long since have been able to do that, but didn't add it to the ddev exec command.

How this PR Solves The Problem:

Allow interaction when doing ddev exec. Kind of makes it identical to ddev ssh, but no direct interaction with the container.

Manual Testing Instructions:

ddev exec mysql
ddev exec vi index.php

Automated Testing Overview:

Related Issue Link(s):

#1023 will be adding bash interpretation to ddev exec
#1162 will eventually make ddev exec handle stdout/stderr and exit values correctly

Release/Deployment notes:

This will be an important announcement, and could conceivably affect some people's workflow.

@rfay rfay mentioned this pull request May 6, 2019
@rfay rfay merged commit f3c9b0d into ddev:master May 7, 2019
@rfay rfay deleted the 20190506_exec_with_tty branch May 7, 2019 04:42
@rfay rfay mentioned this pull request May 9, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant