-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track and list stopped/removed projects, fixes #642 #1600
Conversation
475b1dd
to
3066817
Compare
…h experience with this
3066817
to
0348c8c
Compare
0348c8c
to
405e5b5
Compare
@andrewfrench this is a biggie, requesting some serious look at this from both code and manual testing perspective. Since it changes the whole model from docker-label-query to global-yaml-projectlist, there's just so very much that can go wrong. Thanks for scheduling this in. |
2c5bb41
to
6ec8220
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of code changes here, which look good to me. I've been testing this manually on and off and have failed to trip it up yet, but I'd imagine we'll be extra vigilant for smaller, hidden regressions between now and release.
I've been looking forward to this for awhile - I'm sure I've deleted a project's directory or two and forgetting to I've been playing with the alpha 1 version and so far, so good. I haven't run into any issues. My only comment/request would be that the -mike |
Thanks @ultimike. I think that's a valid request, I thought it would be too big a list for people who work on a lot of projects. Maybe it should go the other way with a --active-only. |
#1636 will change the behavior to |
The Problem/Issue/Bug:
Not all projects have been visible to
ddev list
and related commands. This is a longstanding issue and affects ddev-ui, but is more relevant now thatddev stop
actually removes containers, effectively removing ddev's knowledge of the existence of the project.How this PR Solves The Problem:
TODO:
ddev list
should probably show only active and paused projects. Addddev list --all
for the rest.ddev stop
flag that just stops and removes from global config, doesn't do everything else (nondestructive). Use that in cmd's root_test.go setup so it's not so dangerous.Manual Testing Instructions:
ddev stop -a
andddev list
andddev list --all
(which will show stopped/removed projects)ddev list
There are so very many things that can be broken with this (starting/stopping/pausing by name, whether running or not, conflicting stuff in docker from what's in global config). Please spend some serious time poking at it, and trying to make sure you can recreate bugs.
Automated Testing Overview:
Related Issue Link(s):
OP #642
This should also make ddev-ui work consistently assuming it gets revived.
Release/Deployment notes: