Stop reporting last status from ddev ssh, fixes #1681 #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
#1681 notes that
ddev sshwill display an error on exit if the last shell command returned an error.How this PR Solves The Problem:
Stop reporting the results of ExecWithTty() when using it in the ssh command.
Manual Testing Instructions:
ddev ssh, cause an error withls /tmp/junk, then "exit" orYou should not see an error.
Automated Testing Overview:
No testing changes
Related Issue Link(s):
OP #1681
Release/Deployment notes:
Note that this removes all error checking on the ExecWithTty() command.