Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TYPO3 GFX configuration for ImageMagick6 #1712

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Add TYPO3 GFX configuration for ImageMagick6 #1712

merged 1 commit into from
Jul 22, 2019

Conversation

DanielSiepmann
Copy link
Contributor

In order to configure system to process images. Otherwise possible
existing project configuration within LocalConfiguration.php might
prevent processing, due to configured GraphicsMagick or different paths.

Resolves: #1710

Automated Testing Overview:

I've didn't find instructions how to execute existing tests, therefore none were executed or adjusted or added.

Related Issue Link(s):

#1710

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
All committers have signed the CLA.

In order to configure system to process images. Otherwise possible
existing project configuration within LocalConfiguration.php might
prevent processing, due to configured GraphicsMagick or different paths.

Resolves: #1710
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. My only question is what prompted the PR in the first place. I assume it was a result of the install happening on another host configuration, and the LocalConfiguration.php being checked in (which seems unusual), and thus the LocalConfiguration.php didn't have this properly in it?

@DanielSiepmann
Copy link
Contributor Author

Yes, the use case we encounter are agencies migrating existing project to ddev. Therefore an LocalConfiguration.php already exists on production system, or within VCS already. Whether it's versioned depends on the agencies and people involved. We, as most of our customers, always track this file.

@rfay
Copy link
Member

rfay commented Jul 20, 2019

So although we'd expect LocalConfiguration.php to have "local configuration", it actually is general config, and stuff like credentials is always put into AdditionalConfiguration? I assume they're not checking credentials into LocalConfiguration?

Anyway, thanks for helping me understand.

@DanielSiepmann
Copy link
Contributor Author

That depends on the users ;) Sometimes the AdditionalConfiguration is used to make use of a different loader, e.g. env or yaml loader.

But in context of ddev, this is the place where ddev can configure TYPO3 to work. We could also add something to the docs instead.

@rfay
Copy link
Member

rfay commented Jul 20, 2019

I wonder if there are other things that need to be overwritten by the AdditionalConfiguration for clients in this situation.

Anyway, I'm fine with this, I just have to manually test it.

@rfay rfay merged commit 6146cfa into ddev:master Jul 22, 2019
@DanielSiepmann DanielSiepmann deleted the feature/1710-configure-imagemagick-for-typo3 branch June 1, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure ImageMagick for TYPO3 inside generated AdditionalConfiguration.php
3 participants