Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone docs in config.yaml and add config docs to documentation, fixes #1691 #1721

Merged
merged 5 commits into from
Jul 22, 2019

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 21, 2019

The Problem/Issue/Bug:

  • timezone help missing from config.yaml and docs #1691 points out that config.yaml timezone didn't get documented anywhere
  • In lots of cases we don't have anything in the official documentation about configuration options.
  • Windows can't validate the timezone, but it was making a really annoying statement to this effect every time any ddev command was launched

How this PR Solves The Problem:

  • Add docs to config.yaml (update with ddev config)
  • Add docs to ddev.readthedocs.io
  • Turn off the complaint about validation on Windows. Invalid timezones are ignored (and UTC is used) by both Linux and PHP.

Manual Testing Instructions:

Read the docs.

Automated Testing Overview:

No changes

Related Issue Link(s):

Release/Deployment notes:

@rfay rfay added this to the v1.10 milestone Jul 21, 2019
@rfay rfay merged commit b266721 into ddev:master Jul 22, 2019
@rfay rfay deleted the 20190721_timezone_and_config_docs branch July 22, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant