Ignore .sshimageBuild and .bgsyncimageBuild directories by default, fixes #1762 #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rmcveigh
changed the title
rmcveigh
changed the title
rfay
approved these changes
Aug 4, 2019
rfay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Issue #1762
.sshimageBuild and .bgsyncimageBuild are not ignored by default after performing a
ddev configHow this PR Solves The Problem:
Adjusts the
pkg/ddevapp/config.gofile to ignore the directoriesManual Testing Instructions:
ddev configshould add.sshimagebuildand.bgsyncimagebuildto the.ddev/.gitignorefileAutomated Testing Overview:
Tests were not added due to the simplicity of the change.
Related Issue Link(s):
Issue: #1762
Release/Deployment notes:
A new
ddev configrun should add the.s to the filenames in the.gitignorefile in.ddevif the file is marked to be auto generated/altered.