Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow omit_containers["db"] for projects #1819

Merged
merged 3 commits into from Sep 11, 2019
Merged

Conversation

rfay
Copy link
Member

@rfay rfay commented Aug 29, 2019

The Problem/Issue/Bug:

#1490 requested the ability to not create the db (mariadb) container in cases where it's not used.

People want this when they're using sqlite, or postgres, or another custom database setup.

How this PR Solves The Problem:

  • Allow omit_containers["db"] at the project level (not global)
  • If omit_containers["db"] the dba container is also omitted because it's useless
  • Remove most commands that access the db in the case it's omitted (like export_db)
  • Update ddev describe to leave stuff out.

Manual Testing Instructions:

  • Use omit_containers["db"] and see how it goes
  • Make sure things work without it

Automated Testing Overview:

No changes at this point

Related Issue Link(s):

Release/Deployment notes:

@rfay
Copy link
Member Author

rfay commented Aug 30, 2019

Artifacts for this are at https://circleci.com/gh/drud/ddev/17589#artifacts/containers/0

If using macOS or linux homebrew you can download the macOS tarball, then brew unlink ddev and untar the tarball, cp ddev /usr/local/bin. When done, you can rm /usr/local/bin/ddev && brew link ddev again. For windows, just use the installer.

@rfay rfay merged commit 22625e2 into ddev:master Sep 11, 2019
@rfay rfay deleted the 20190829_omit_db branch September 11, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant