Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use much simpler TYPO3 trustedHostsPattern #1835

Merged
merged 2 commits into from Oct 20, 2019

Conversation

rfay
Copy link
Member

@rfay rfay commented Sep 17, 2019

The Problem/Issue/Bug:

Several recent PRs have tried to catch up with TYPO3 v1.10's rejection of ".*" as trustedHostsPattern, and it's gotten super complex.

How this PR Solves The Problem:

Since TYPO3 only checks and complains about the literal .* we might as well fool it by using .*.*. It's for development after all!

Manual Testing Instructions:

Install TYPO3 v10 using composer, then do an install

  • Test with various hostnames/fqdns
  • Test with ngrok/ddev share

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

@rfay rfay force-pushed the 20190917_typo3_trusted_simplification branch from 83a533d to b8ea5bd Compare October 19, 2019 14:53
@rfay
Copy link
Member Author

rfay commented Oct 19, 2019

Rebased this and tested with a TYPO3 v10 install and then access, and with ddev share and it seems to work fine. When it passes tests I think it's good to pull.

@rfay rfay merged commit 1bdcde3 into ddev:master Oct 20, 2019
@rfay rfay deleted the 20190917_typo3_trusted_simplification branch October 20, 2019 07:02
@gilbertsoft
Copy link
Member

@rfay This does not work for TYPO3 8.7.29, getting a warning in the install tool. But as this version is EOL in 5 months I don't think we have to change this again. And I'm not sure if there was a running version for 8.7 at all. The user could simply click ignore and the installation continues without any other issues.

@rfay
Copy link
Member Author

rfay commented Nov 14, 2019

The problem on TYPO3 v8 is that it doesn't actually include AdditionalSettings.php during install. As a result we recommend installing using http in the quickstart. @jonaseberle made a patch to fix this in v9, https://review.typo3.org/c/Packages/TYPO3.CMS/+/61374

So the answer in v8 is "use http or ignore the warning"

@gilbertsoft
Copy link
Member

Yeah, I remember now. It's only a warning on the first install, afterwards everything works as expected. No need to not to use TLS for this one time step imho. But thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants