WordPress: Use the secure URL for WP_HOME
#1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Seems reasonable to me. I see this actually ends up getting used as $WP_HOME at https://github.com/drud/ddev/blob/2948e7e5d250abfc85dbed76e5af6804e15a912c/pkg/ddevapp/wordpress.go#L143 |
|
In #1862 DDEV_PRIMARY_URL and app.GetPrimaryURL() are introduced. I think that will be better to use than just using the secure URL by default. |
|
#1862 has landed, so this can now use the primary URL, will take a look a bit later. In the meantime, rebased this to current upstream/master. |
|
I took the liberty of rebasing this and using the app.GetPrimaryURL(). However, it doesn't actually work yet with WP because of the basic problem described in #1736 - we need to get that one fixed before this has any value. |
rfay
changed the title
WP_HOMEWP_HOME
Since DDEV instances default to `https`, it makes sense to keep `WP_HOME` the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Every time I run
ddev config, DDEV overrides thewp-config-ddev.phpfor theWP_HOMEconstant, and uses HTTP protocol for that URL.However DDEV already defaults to secure URLs, this setting should match that too.
How this PR Solves The Problem:
Changes
DeployURLto use a secure URL, so thatWP_HOMEcan inherit that too.